Don't disallow adding a DIM to an interface #48801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
commented
Sep 30, 2025
gewarren
commented
Sep 30, 2025
|
Thanks so much for this! |
BillWagner
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Thanks @gewarren
This looks good, with a few small changes.
Co-authored-by: Bill Wagner <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation and rules regarding default interface members (DIMs) to clarify that adding a DIM to an interface is not strictly disallowed, but requires judgment. The changes correct terminology and reorganize content for better flow.
- Updates library change rules to allow adding static, non-abstract, non-virtual members to interfaces in certain scenarios
- Corrects terminology from "default interface methods" to "default interface members" for consistency
- Reorganizes the interface keyword documentation to improve readability and flow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/core/compatibility/library-change-rules.md | Updates breaking change rules to allow adding DIMs to interfaces with judgment, removes extra whitespace |
| docs/csharp/language-reference/keywords/interface.md | Reorganizes content structure and corrects access modifier descriptions for better clarity |
| docs/csharp/whats-new/csharp-version-history.md | Corrects terminology from "methods" to "members" and fixes comma placement |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42748.
Also reorganizes interface keyword doc as it didn't seem to flow properly.
cc @jskeet.
Internal previews